[webkit-reviews] review denied: [Bug 103865] [Qt] Don't rely on QMimeDatabase for essential MIME types : [Attachment 177443] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 103865: [Qt] Don't rely on QMimeDatabase for essential MIME types
https://bugs.webkit.org/show_bug.cgi?id=103865

Attachment 177443: Patch
https://bugs.webkit.org/attachment.cgi?id=177443&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177443&action=review


> Source/WebCore/ChangeLog:9
> +	   Extend the short static list to also include MIME types essential
WebKit,

to WebKit

> Source/WebCore/platform/qt/MIMETypeRegistryQt.cpp:59
> +    { "xls", ".xls", "text/xsl" },

I didn't know we supported Excel sheets with WebKit :P

> Source/WebCore/platform/qt/MIMETypeRegistryQt.cpp:76
> +    // FIXME: We should get all the matched mimetypes with
mimeTypesForFileName, and prefer one we support.

mimeTypesForFileName -> mimeTypesForFile?

> Source/WebCore/platform/qt/MIMETypeRegistryQt.cpp:77
> +    // But initializeSupportedImageMIMETypes will first have to stop using
getMIMETypeForExtension.

Could you write why? I don't have enough context to understand this part.