[webkit-reviews] review granted: [Bug 103925] Style sharing: Allow sharing between elements with classes not referenced by any selectors. : [Attachment 177647] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 103925: Style sharing: Allow sharing between elements with classes not
referenced by any selectors.
https://bugs.webkit.org/show_bug.cgi?id=103925

Attachment 177647: Patch
https://bugs.webkit.org/attachment.cgi?id=177647&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=177647&action=review


> Source/WebCore/css/StyleResolver.cpp:967
> +	   m_elementAffectedByClassRules = m_element && m_element->hasClass()
&& classNamesAffectedByRules(m_element->classNames());

We should really factor the style sharing code differently so using
StyleResolver member for passing things around wouldn't be needed. Better done
separately though.