[webkit-reviews] review denied: [Bug 104071] Web Inspector: better coverage for inspector/profiler/cpu-profiler-profiling-without-inspector.html : [Attachment 177624] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 104071: Web Inspector: better coverage for
inspector/profiler/cpu-profiler-profiling-without-inspector.html
https://bugs.webkit.org/show_bug.cgi?id=104071

Attachment 177624: Patch
https://bugs.webkit.org/attachment.cgi?id=177624&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177624&action=review


>
LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector.html:78

> +    const roundingThreshold = 50; // Time should be good within 50ms

This will be flaky. You should test that the (actualValue > expectedValue -
50).