[webkit-reviews] review granted: [Bug 104059] nrwt: remove two unused parameters from a function : [Attachment 177598] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 104059: nrwt: remove two unused parameters from a function
https://bugs.webkit.org/show_bug.cgi?id=104059

Attachment 177598: Patch
https://bugs.webkit.org/attachment.cgi?id=177598&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177598&action=review


> Tools/ChangeLog:3
> +	   nrwt: remove two unused parameters from a function

It would have been better if this bug title referred to
interpret_test_failures.

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:60
>      """Interpret test failures and returns a test result as dict.

You might as well as delete this block comment. It refers to parameters you’re
deleting this patch.
And comments like:
"    Args:
	failures: list of test failures
    Returns:
	A dictionary like {'is_missing_text': True, …}"
doesn’t add much value beyond the code beneath it.