[webkit-reviews] review denied: [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector : [Attachment 177565] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 103513: Provide the backend for exposing the layer tree to the Web
Inspector
https://bugs.webkit.org/show_bug.cgi?id=103513

Attachment 177565: Patch
https://bugs.webkit.org/attachment.cgi?id=177565&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177565&action=review


> Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:67
> +    m_instrumentingAgents->setInspectorLayerTreeAgent(0);

There is no need to do this here.

> Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:83
> +    enable(0);

This is wrong: enable will check for the state and will return early.

> Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:96
> +    m_enabled = true;

I thought we agreed that you did not need to mirror layerTreeAgentEnabled