[webkit-reviews] review granted: [Bug 103921] IndexedDB: Stub out transaction-backend methods : [Attachment 177585] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 15:46:14 PST 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 103921: IndexedDB: Stub out transaction-backend methods
https://bugs.webkit.org/show_bug.cgi?id=103921

Attachment 177585: Patch
https://bugs.webkit.org/attachment.cgi?id=177585&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177585&action=review


> Source/WebCore/Modules/indexeddb/IDBFactory.cpp:132
> +    // FIXME: pass the transactionId in here

File a bug and reference here?

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.h:52
> +    // FIXME: Remove old method in
https://bugs.webkit.org/show_bug.cgi?id=103923.

old -> this here and elsewhere. "This method" (that is, the one just below) is
easier to understand out of the context of this patch.


More information about the webkit-reviews mailing list