[webkit-reviews] review granted: [Bug 103799] [CSS Grid Layout] Implement CSS parsing and handling for <track-minmax> : [Attachment 177566] Rebaselined patch with extra testing, fixed a tiny coding style violation (no else after return).

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 14:36:08 PST 2012


Tony Chang <tony at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 103799: [CSS Grid Layout] Implement CSS parsing and handling for
<track-minmax>
https://bugs.webkit.org/show_bug.cgi?id=103799

Attachment 177566: Rebaselined patch with extra testing, fixed a tiny coding
style violation (no else after return).
https://bugs.webkit.org/attachment.cgi?id=177566&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177566&action=review


> Source/WebCore/rendering/RenderGrid.cpp:147
> +	       // FIXME: we stil need to support calc() here (bug 103761)

Nit: Add a period to the end of this sentence and capitalize the first letter.


More information about the webkit-reviews mailing list