[webkit-reviews] review granted: [Bug 104032] commit-queue can get stuck with a local commit : [Attachment 177536] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 13:44:30 PST 2012


Dirk Pranke <dpranke at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 104032: commit-queue can get stuck with a local commit
https://bugs.webkit.org/show_bug.cgi?id=104032

Attachment 177536: Patch
https://bugs.webkit.org/attachment.cgi?id=177536&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
As discussed over IRC, I think this patch is okay, but
"clean_working_directory" means something different than "reset to merge base"
to me ... maybe we should rename this command/method to reset_to_master() or
something?


More information about the webkit-reviews mailing list