[webkit-reviews] review denied: [Bug 103999] Rework bug 97927 to not depend on RenderLayer::allowsScrolling : [Attachment 177484] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 13:02:22 PST 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 103999: Rework bug 97927 to not depend on RenderLayer::allowsScrolling
https://bugs.webkit.org/show_bug.cgi?id=103999

Attachment 177484: patch
https://bugs.webkit.org/attachment.cgi?id=177484&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177484&action=review


It would be nice to only have the "scrollsOverflowX() && scrollWidth() !=
clientWidth()" logic in one place; here it's in both RenderLayer and RenderBox,
and the various width implementations are subtly different.

> Source/WebCore/rendering/RenderBox.cpp:621
> +    bool hasOverflowAndAllowsScrollingInThatDirection = (scrollsOverflowX()
&& scrollWidth() != clientWidth())

Awkward variable name. How about hasScrollableOverflow?


More information about the webkit-reviews mailing list