[webkit-reviews] review denied: [Bug 104014] [CSS3 Backgrounds and Borders] Allow the CSS3 background position offset for background shorthand. : [Attachment 177510] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Alexis Menard (darktears)
<alexis at webkit.org>'s request for review:
Bug 104014: [CSS3 Backgrounds and Borders] Allow the CSS3 background position
offset for background shorthand.
https://bugs.webkit.org/show_bug.cgi?id=104014

Attachment 177510: Patch
https://bugs.webkit.org/attachment.cgi?id=177510&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
Looking at it again, it looks like they are missing, since no test needs to be
adapted. Please add negative tests as well, where the position is partly
between background-position and -size, where you have 1, 2, 3, 4 or fife
values. I just can see tests with 4 values. That is not enough. I assume we
have tests for 1 and 2 values, but 3 and 5 are missing.