[webkit-reviews] review granted: [Bug 99493] CSS cursor property should support webkit-image-set : [Attachment 177002] Tweaks based on suggestions from bethdakin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 11:25:48 PST 2012


Beth Dakin <bdakin at apple.com> has granted Rick Byers <rbyers at chromium.org>'s
request for review:
Bug 99493: CSS cursor property should support webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=99493

Attachment 177002: Tweaks based on suggestions from bethdakin
https://bugs.webkit.org/attachment.cgi?id=177002&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177002&action=review


> Source/WebCore/ChangeLog:6747
> +	   (StyleCachedImageSet::cachedImage): Override new virtual.

This Changelog merge seems like it might be messed up?

> Source/WebCore/css/CSSParser.cpp:1908
> +	   // [ [ <uri> | -webkit-image-set(...) ] [<x> <y>]?,]*

If this matches the spec, then I take back my previous objection.


More information about the webkit-reviews mailing list