[webkit-reviews] review granted: [Bug 101677] REGRESSION(r126683): Table cell are getting borders when the style doesn't mention any : [Attachment 177327] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 10:52:28 PST 2012


Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 101677: REGRESSION(r126683): Table cell are getting borders when the style
doesn't mention any
https://bugs.webkit.org/show_bug.cgi?id=101677

Attachment 177327: Patch
https://bugs.webkit.org/attachment.cgi?id=177327&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177327&action=review


r=me!

> LayoutTests/fast/table/td-bordercolor-attribute.html:70
> +    shouldBeEqualToString('document.defaultView.getComputedStyle(cell,
null).getPropertyValue("border-top-color")', "rgb(0, 0, 0)");

For the next time: you can do window.getComputedStyle (shorter is better!) and
Firefox don't need the null parameter anymore per
https://developer.mozilla.org/en-US/docs/DOM/window.getComputedStyle


More information about the webkit-reviews mailing list