[webkit-reviews] review canceled: [Bug 104009] Add an helper function in CSSParser to check for '/' character. : [Attachment 177505] Patch

[bugzilla-daemon at webkit.org]

Alexis Menard (darktears) <alexis at webkit.org> has canceled  review:
Bug 104009: Add an helper function in CSSParser to check for '/' character.
https://bugs.webkit.org/show_bug.cgi?id=104009

Attachment 177505: Patch
https://bugs.webkit.org/attachment.cgi?id=177505&action=review

------- Additional Comments from Alexis Menard (darktears) <alexis at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177505&action=review


>> Source/WebCore/css/CSSParser.cpp:1657
>> +	return value && value->unit == CSSParserValue::Operator &&
value->iValue == '/';
> 
> This adds an extra null check. Seems like an unwanted change. Maybe make this
take a CSSParserValue& and put * characters at the call sites? Or just leave
out the null check? Or replace it with an assertion?

I can just remove it sure so we keep the same behavior as before.