[webkit-reviews] review granted: [Bug 103979] [V8] V8Binding::v8ExternalString() is redundant : [Attachment 177436] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 103979: [V8] V8Binding::v8ExternalString() is redundant
https://bugs.webkit.org/show_bug.cgi?id=103979

Attachment 177436: Patch
https://bugs.webkit.org/attachment.cgi?id=177436&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177436&action=review


> Source/WebCore/bindings/v8/V8Binding.h:107
> +	   return str.isNull() ? v8::Handle<v8::Value>(v8::Null()) :
v8::Handle<v8::Value>(v8String(str, isolate));

Shouldn't we pass the isolate to v8Null(isolate) here?