[webkit-reviews] review denied: [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector : [Attachment 177472] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 103513: Provide the backend for exposing the layer tree to the Web
Inspector
https://bugs.webkit.org/show_bug.cgi?id=103513

Attachment 177472: Patch
https://bugs.webkit.org/attachment.cgi?id=177472&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177472&action=review


Post a version with some of these tweaks, especially the dumping typeof instead
of dropping the replaced properties, and I'll r+ it.

> LayoutTests/inspector-protocol/layer-tree.html:92
> +	       parameters: { "layerId": lastId },

No spaces inside {}.

> LayoutTests/inspector-protocol/layer-tree.html:103
> +	       parameters: { "nodeId": id },

No spaces inside {}.

>> LayoutTests/inspector-protocol/layer-tree.html:146
>> +	    function recurse (layer) {
> 
> recurse(layer)

The { should also be on a new line.

>> LayoutTests/inspector-protocol/layer-tree.html:170
>> +		return (key === "layerId") ? undefined : value;
> 
> style: please drop redundant parenthesis
> we typically dump typeof value instead of value if value is non-stable --
this occasionally helps to catch regressions for values that are missing or of
a wrong type.

Should memory be replaced too? I don't think it will stay constant and might
lead to flakiness. Unless it is always constant based on the width and height.