[webkit-reviews] review granted: [Bug 103978] [V8] Remove IntegerCache::m_initialized : [Attachment 177434] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 10:07:00 PST 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 103978: [V8] Remove IntegerCache::m_initialized
https://bugs.webkit.org/show_bug.cgi?id=103978

Attachment 177434: Patch
https://bugs.webkit.org/attachment.cgi?id=177434&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177434&action=review


> Source/WebCore/bindings/v8/V8ValueCache.cpp:103
> -void IntegerCache::createSmallIntegers(v8::Isolate* isolate)
> +IntegerCache::IntegerCache()

I probably would have passed in isolate to the constructor, but this is fine
too.


More information about the webkit-reviews mailing list