[webkit-reviews] review granted: [Bug 103971] FontPlatformData has unnecessary m_textOrientation member : [Attachment 177417] Remove FontPlatformData::m_textOrientation

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org <mitz at webkit.org>'s
request for review:
Bug 103971: FontPlatformData has unnecessary m_textOrientation member
https://bugs.webkit.org/show_bug.cgi?id=103971

Attachment 177417: Remove FontPlatformData::m_textOrientation
https://bugs.webkit.org/attachment.cgi?id=177417&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177417&action=review


> Source/WebCore/ChangeLog:8
> +	   Nothing in SimpleFontData depends on the FontPlatformData’s
textOrientation, so we don’t

Is the strange character here you doing something wrong, or bugs.webkit.org
doing something wrong?

>> Source/WebCore/css/CSSFontFaceSource.cpp:115
>> +			   | (fontDescription.orientation() == Vertical ? 4 :
0) | (syntheticBold ? 2 : 0) | (syntheticItalic ? 1 : 0);
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

For what it’s worth I prefer the 4-space indent that the style script calls
for. But I don’t think adding formatting changes to this patch is a good idea.