[webkit-reviews] review granted: [Bug 103480] [chromium] Implement cache eviction logic in ImageDecodingStore : [Attachment 177408] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 22:37:42 PST 2012


James Robinson <jamesr at chromium.org> has granted Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 103480: [chromium] Implement cache eviction logic in ImageDecodingStore
https://bugs.webkit.org/show_bug.cgi?id=103480

Attachment 177408: Patch
https://bugs.webkit.org/attachment.cgi?id=177408&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177408&action=review


> Source/WebCore/ChangeLog:10
> +	   - Setting cache limit (default is 8MB)

this needs an update

> Source/WebCore/platform/graphics/chromium/ImageDecodingStore.h:99
> +	   // FIXME: getSafeSize() returns size in bytes trunscated to a
32-bits integer.

typo trunscated -> truncated


More information about the webkit-reviews mailing list