[webkit-reviews] review granted: [Bug 103963] nrwt: only store the total number of tests in the result summary : [Attachment 177398] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 19:55:51 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 103963: nrwt: only store the total number of tests in the result summary
https://bugs.webkit.org/show_bug.cgi?id=103963

Attachment 177398: Patch
https://bugs.webkit.org/attachment.cgi?id=177398&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177398&action=review


> Tools/ChangeLog:3
> +	   nrwt: only store the total number of tests in the result summary

It’s probably better to rename this bug to something like:
NRWT: ResultSummary should only store the total number of tests instead of the
list of tests.
Otherwise it sounds as if we’re restricting the places we where we ever store
the total number of tests to be ResultSummary.


More information about the webkit-reviews mailing list