[webkit-reviews] review denied: [Bug 103952] Scroll gestures should not create wheel events : [Attachment 177387] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 103952: Scroll gestures should not create wheel events
https://bugs.webkit.org/show_bug.cgi?id=103952

Attachment 177387: Patch
https://bugs.webkit.org/attachment.cgi?id=177387&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177387&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests (OOPS!).

oops should not be here.

> Source/WebCore/page/EventHandler.cpp:2752
> +    Node* node = m_scrollGestureHandlingNode.get();
> +    if ((!node || !node->renderer()) &&
!hitTestForScrollGestureHandlingNode(e))
> +	   return false;
> +
> +    node = m_scrollGestureHandlingNode.get();
> +    RenderObject* latchedRenderer = node->renderer();
> +
> +    IntSize delta(-e.deltaX(), -e.deltaY());
> +    if (delta.isZero())
> +	   return false;
> +    
> +    bool restrictedByLineClamp = false;
> +    if (latchedRenderer->parent())
> +	   restrictedByLineClamp =
!latchedRenderer->parent()->style()->lineClamp().isNone();
> +
> +    if (latchedRenderer->hasOverflowClip() && !restrictedByLineClamp) {
> +	   if (e.type() == PlatformEvent::GestureScrollUpdatePropagated)
> +	       latchedRenderer->enclosingLayer()->scrollByRecursively(delta,
RenderLayer::ScrollOffsetClamped);
> +	   else {
> +	       IntSize scrollOffset =
latchedRenderer->enclosingLayer()->scrollOffset();
> +	       IntSize newScrollOffset = scrollOffset + delta;
> +	      
latchedRenderer->enclosingLayer()->scrollToOffset(newScrollOffset,
RenderLayer::ScrollOffsetClamped);
> +	   }
> +	   setFrameWasScrolledByUser();
> +	   return true;
> +    }

should live in RenderLayer. r- due to that.

> Source/WebCore/page/EventHandler.cpp:2790
> +    return (node && node->renderer());

no outter parentheses needed.

> Source/WebCore/platform/PlatformEvent.h:55
> +	   GestureScrollUpdatePropagated,
> +	   GestureScrollUpdateNotPropagated,

I am not in love with these names. No better suggestion at the moment though.