[webkit-reviews] review requested: [Bug 91878] [CSS Exclusions] Enable shape-inside for multiple-segment polygons : [Attachment 177374] Updating patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 16:53:52 PST 2012


Bear Travis <betravis at adobe.com> has asked  for review:
Bug 91878: [CSS Exclusions] Enable shape-inside for multiple-segment polygons
https://bugs.webkit.org/show_bug.cgi?id=91878

Attachment 177374: Updating patch
https://bugs.webkit.org/attachment.cgi?id=177374&action=review

------- Additional Comments from Bear Travis <betravis at adobe.com>
Incorporating feedback from Julien. Making most of the changes suggested above.
Still considering how best to address the following:
begin/endPlacingBoxRanges methods are in place because they should ideally be
called before/after box ranges are placed. I would still like to emphasize
this, even if renaming the methods.
I would like to avoid adding an enumeration for m_startsSegment, as its use is
infrequent, and callers either used a passed-in value, or
BidiRun::m_startsSegment itself.
needsWordSpacing is used at the end of computeInlineDirectionPositionsForLine.


More information about the webkit-reviews mailing list