[webkit-reviews] review granted: [Bug 103661] webkitpy's run_webkit_tests should initialize the printer earlier on : [Attachment 177332] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 3 15:00:53 PST 2012
Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 103661: webkitpy's run_webkit_tests should initialize the printer earlier
on
https://bugs.webkit.org/show_bug.cgi?id=103661
Attachment 177332: Patch
https://bugs.webkit.org/attachment.cgi?id=177332&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177332&action=review
FANTASTIC.
> Tools/Scripts/webkitpy/layout_tests/port/mac.py:241
> - except ScriptError, e:
> + except ScriptError:
> _log.warning('Unable to sample process.')
We could log the actual error. :)
More information about the webkit-reviews
mailing list