[webkit-reviews] review denied: [Bug 85385] Caret rendered at incorrect location inside empty table cell : [Attachment 146584] Patch (with rebaseline fix)

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Shezan Baig
<shezbaig.wk at gmail.com>'s request for review:
Bug 85385: Caret rendered at incorrect location inside empty table cell
https://bugs.webkit.org/show_bug.cgi?id=85385

Attachment 146584: Patch (with rebaseline fix)
https://bugs.webkit.org/attachment.cgi?id=146584&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146584&action=review


>>> Source/WebCore/rendering/RenderTableCell.cpp:190
>>> +}
>> 
>> After doing some search, I've started to think that this isn't the right
fix.
> 
> Hmm, but wouldn't returning true for 'hasLineIfEmpty' cause the empty td's to
have the right line height?

The problem is that "right line height" is superfluous here since it doesn’t
really have a height on other browsers.

>> LayoutTests/editing/deleting/5206311-2-expected.txt:-30
>> -|	      <br>
> 
> We need these br for empty td's to have the right line height.

To clarify this, we need to produce markup that could be rendered by other
browsers properly.