[webkit-reviews] review denied: [Bug 103621] Caret is incorrectly painted for a contenteditable <div> containing a <br> in vertical writing mode : [Attachment 176715] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 103621: Caret is incorrectly painted for a contenteditable <div> containing
a <br> in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=103621

Attachment 176715: Patch
https://bugs.webkit.org/attachment.cgi?id=176715&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176715&action=review


> Source/WebCore/dom/Position.cpp:845
> +	       if ((o->isText() && (o->style()->isHorizontalWritingMode() ?
toRenderText(o)->linesBoundingBox().height() :
toRenderText(o)->linesBoundingBox().width()))
> +		   || (o->isBox() && (o->style()->isHorizontalWritingMode() ?
toRenderBox(o)->borderBoundingBox().height() :
toRenderBox(o)->borderBoundingBox().width())))

We should be calling logicalWidth & logicalHeight instead.

>
LayoutTests/editing/selection/caret-in-div-containing-br-in-vertical-mode.html:
17
> +    /* Caret rect in div containing text. */

This comment repeats the code. Please remove it.

>
LayoutTests/editing/selection/caret-in-div-containing-br-in-vertical-mode.html:
22
> +    /* Caret rect in div containing no text. */

Ditto.