[webkit-reviews] review granted: [Bug 103777] [Resource Timing] Record and report initiator : [Attachment 177038] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 3 12:56:39 PST 2012
Nate Chapin <japhet at chromium.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 103777: [Resource Timing] Record and report initiator
https://bugs.webkit.org/show_bug.cgi?id=103777
Attachment 177038: Patch
https://bugs.webkit.org/attachment.cgi?id=177038&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177038&action=review
LGTM, just some formatting pedantry:
> Source/WebCore/loader/cache/CachedResourceLoader.cpp:712
> +#if ENABLE(RESOURCE_TIMING)
newlines before and after this #if/#else/#endif block, please.
> Source/WebCore/loader/cache/CachedResourceLoader.cpp:724
> +#endif
This is long enough that an // ENABLE(RESOURCE_TIMING) would make me happy.
More information about the webkit-reviews
mailing list