[webkit-reviews] review denied: [Bug 103911] Web Inspector: more robust treeoutline.findTreeElement : [Attachment 177296] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied johnjbarton
<johnjbarton at chromium.org>'s request for review:
Bug 103911: Web Inspector: more robust treeoutline.findTreeElement
https://bugs.webkit.org/show_bug.cgi?id=103911

Attachment 177296: Patch
https://bugs.webkit.org/attachment.cgi?id=177296&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177296&action=review


> Source/WebCore/inspector/front-end/treeoutline.js:279
> +	   function oneLevel() {

{ should go on the next line

I also don't think this is right: imagine you get here due to
isAncestor(item.representedObject, representedObject) returning true above. And
there are no tree elements created for the path from root to given
representedObject yet. You get into recursive findTreeElement for the parent
object as the next step, but oneLevel (isAncestor substitude) returns false and
you never call onpopulate on the parent.

> Source/WebCore/inspector/front-end/treeoutline.js:282
> +	   function noAncestors() {

ditto