[webkit-reviews] review denied: [Bug 102686] [V8] toFastV8 for non-Nodes : [Attachment 177259] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 11:54:50 PST 2012


Adam Barth <abarth at webkit.org> has denied Dan Carney <dcarney at google.com>'s
request for review:
Bug 102686: [V8] toFastV8 for non-Nodes
https://bugs.webkit.org/show_bug.cgi?id=102686

Attachment 177259: Patch
https://bugs.webkit.org/attachment.cgi?id=177259&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177259&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:585
> +	   my $fastWrapper = $codeGenerator->IsSubType($interface, "Node") ?
"impl->wrapper()" : "DOMDataStore::mainWorldStore()->get(impl)";

Very clever!

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1076
> +	   if (IsDOMNodeType($interfaceName)) {

In principle, we should be able to use toV8Fast whenever $interfaceName is
ScriptWrappable.  We can have the compiler do the dispatch by exposing
DOMDataStore::wrapperIsStoredInObject publicly.  We can do that in a subsequent
patch if you like.


More information about the webkit-reviews mailing list