[webkit-reviews] review denied: [Bug 103510] Reduce the children repaints when moved multiple times during the layout : [Attachment 177239] Patch for landing

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 103510: Reduce the children repaints when moved multiple times during the
layout
https://bugs.webkit.org/show_bug.cgi?id=103510

Attachment 177239: Patch for landing
https://bugs.webkit.org/attachment.cgi?id=177239&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177239&action=review


Looks pretty good. Needs a couple small improvements.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:336
> +    WTF::Vector<LayoutRect> childrenOldRects;

Should be just Vector. Not WTF::Vector. Also, we should choose some amount of
inline capacity to cut down on memory allocation and make performance better. A
number large enough that it’s often larger than the number of children, but not
so large that we use a ton of stack space.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:370
> +void RenderFlexibleBox::childrenFrameRects(WTF::Vector<LayoutRect>&
childrenFrameRects)

No WTF prefix needed here.

A function like this that uses an out parameter should have “get” in its name.
Or “append” to make clear its contract is that it appends to an existing
vector.