[webkit-reviews] review granted: [Bug 103907] Make MainResourceLoader not use m_frame directly : [Attachment 177275] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 103907: Make MainResourceLoader not use m_frame directly
https://bugs.webkit.org/show_bug.cgi?id=103907

Attachment 177275: patch
https://bugs.webkit.org/attachment.cgi?id=177275&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177275&action=review


Great!

> Source/WebCore/loader/MainResourceLoader.h:54
> -    static PassRefPtr<MainResourceLoader> create(Frame*);
> +    static PassRefPtr<MainResourceLoader> create(DocumentLoader*);

Even though it’s not a common pattern in our code today, we might consider
using references rather than pointers in cases like this if the pointer is not
allowed to be zero.