[webkit-reviews] review denied: [Bug 103851] Don't use an OwnPtr for Node rare data : [Attachment 177175] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 103851: Don't use an OwnPtr for Node rare data
https://bugs.webkit.org/show_bug.cgi?id=103851

Attachment 177175: Patch
https://bugs.webkit.org/attachment.cgi?id=177175&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This change doesn’t seem good. Using a return type of PassOwnPtr is an
excellent way to make it clear to people reading the code what the lifetime of
a returned object is, even if we use leakPtr right after the fact. Moving to a
raw pointer does not seem like an improvement, unless there is some concrete
benefit of doing so.

Using a return type of OwnPtr is incorrect, though, and should be fixed.