[webkit-reviews] review granted: [Bug 103844] [Qt] Use a separate QWEBKITWIDGETS_EXPORT macro for WebKitWidgets : [Attachment 177241] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 103844: [Qt] Use a separate QWEBKITWIDGETS_EXPORT macro for WebKitWidgets
https://bugs.webkit.org/show_bug.cgi?id=103844

Attachment 177241: Patch
https://bugs.webkit.org/attachment.cgi?id=177241&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177241&action=review


Excellent solution. Fully agreed that this is much cleaner. Hadn't realized
that qt_module.prf sets the QT_BUILDING_*_LIB macros automatically. Lovely.

Carefuly when landing wrt MSVC

> Source/WebKit/qt/WidgetSupport/InitWebKitQt.cpp:33
> -Q_DECL_EXPORT void initializeWebKitWidgets()
> +void initializeWebKitWidgets()

I think that this is likely to cause compilation errors on Windows. I've seen
MSVC at least complain that the declaration had to match the definition. I
suggest to land carefully in trunk first to see of the MSVC bot complains or
not.