[webkit-reviews] review denied: [Bug 103744] Make svg/dom/viewspec-parser-*.html non-flaky : [Attachment 177203] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Jussi Kukkonen (jku)
<jussi.kukkonen at intel.com>'s request for review:
Bug 103744: Make svg/dom/viewspec-parser-*.html non-flaky
https://bugs.webkit.org/show_bug.cgi?id=103744

Attachment 177203: Patch
https://bugs.webkit.org/attachment.cgi?id=177203&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177203&action=review


You removed by far to  many test scenarios. Something that might work for me is
splitting the test into multiple files and keep the flacky parts in the
original parser files. Exponent parsing and correct comma parsing is very
necessary.

> LayoutTests/svg/dom/viewspec-parser-1-expected.txt:-73
> -Loaded: resources/viewspec-target.svg#svgView(viewBox(74- 9.(+ e.0e635
> -Parsed: [initial view] from: svgView(viewBox(74- 9.(+ e.0e635
> -
> -Loaded: resources/viewspec-target.svg#svgView(viewBox(-9,).8e7e4e9ee
> -Parsed: [initial view] from: svgView(viewBox(-9,).8e7e4e9ee 
> -
> -Loaded: resources/viewspec-target.svg#svgView(viewBox(49-,,4)30378.052
> -Parsed: [initial view] from: svgView(viewBox(49-,,4)30378.052
> -
> -Loaded: resources/viewspec-target.svg#svgView(viewBox(e7863e
> -Parsed: [initial view] from: svgView(viewBox(e7863e
> -
> -Loaded: resources/viewspec-target.svg#svgView(viewBox(0
> -Parsed: [initial view] from: svgView(viewBox(	0
> -
> -Loaded: resources/viewspec-target.svg#svgView(viewBox(e72(e,49.7.
> -Parsed: [initial view] from: svgView(viewBox(e72(	e	,49.7.
> -
> -Loaded: resources/viewspec-target.svg#svgView(viewBox(e55,
> -Parsed: [initial view] from: svgView(viewBox(e55, 

All this seems not to be covered by the test anymore.