[webkit-reviews] review requested: [Bug 103874] [BlackBerry] VKB flickers in and out when tapping on webview after text selection on URL bar : [Attachment 177225] patch

[bugzilla-daemon at webkit.org]

Sean Wang <xuewen.wang at torchmobile.com.cn> has asked  for review:
Bug 103874: [BlackBerry] VKB flickers in and out when tapping on webview after
text selection on URL bar
https://bugs.webkit.org/show_bug.cgi?id=103874

Attachment 177225: patch
https://bugs.webkit.org/attachment.cgi?id=177225&action=review

------- Additional Comments from Sean Wang <xuewen.wang at torchmobile.com.cn>
>It looks safe but that assumes the change event will re trigger, if not we
risk having a stale selection
>overlay if the layout change modifies it.

There is a function "void FrameView::performPostLayoutTasks()" which will call
FrameSelection::updateAppearance() on every time the FrameView layout is
finished. So I think the selection changing will be notified at last.

If we don't ensure it, another solution is to check and layoutIfNeeded at the
beginning of "SelectionHandler::selectionPositionChanged()".