[webkit-reviews] review denied: [Bug 97630] Add DeviceProximityController to support Device Proximity Events. : [Attachment 177079] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 97630: Add DeviceProximityController to support Device Proximity Events.
https://bugs.webkit.org/show_bug.cgi?id=97630

Attachment 177079: Patch
https://bugs.webkit.org/attachment.cgi?id=177079&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177079&action=review


> Source/WebCore/Modules/proximity/DeviceProximityClient.h:53
> +protected:

In principle, client superclasses shouldn't have any state. It should be pure
virtual class.

> Source/WebCore/Target.pri:255
> +    accessibility/AccessibilityImageMapLink.cpp \

Why change this?

> Source/WebCore/platform/mock/DeviceProximityClientMock.h:1
> +/*

Could we implement this in testing/ and get rid of new DRT API?
Having mock implementation built into WebCore and adding new DRT API are both
unfortunate
and better to be avoided if possible.