[webkit-reviews] review granted: [Bug 99285] [EFL][WK2] Add support for a zoom level setting to MiniBrowser : [Attachment 177185] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 2 23:36:25 PST 2012
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted KyungTae Kim
<ktf.kim at samsung.com>'s request for review:
Bug 99285: [EFL][WK2] Add support for a zoom level setting to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=99285
Attachment 177185: Patch
https://bugs.webkit.org/attachment.cgi?id=177185&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177185&action=review
Looks good to me now.
> Tools/MiniBrowser/efl/main.c:59
> + if (level < 0 || level >= sizeof(zoomLevels) / sizeof(int))
Don't you need to add a fail message ?
More information about the webkit-reviews
mailing list