[webkit-reviews] review denied: [Bug 103843] Coordinated Graphics: Flush compositing states of layers by the tree order. : [Attachment 177156] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 2 16:53:55 PST 2012


Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 103843: Coordinated Graphics: Flush compositing states of layers by the
tree order.
https://bugs.webkit.org/show_bug.cgi?id=103843

Attachment 177156: Patch
https://bugs.webkit.org/attachment.cgi?id=177156&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177156&action=review


> Source/WebKit2/ChangeLog:16
> +	   In addition, this patch removes updateViewport() in
> +	   LayerTreeCoordinatorProxy::setRootCompositingLayer() because
> +	   LayerTreeCoordinatorProxy::didRenderFrame() is always called after
> +	   setting the root layer.

Different patch.

> Source/WebKit2/ChangeLog:20
> +	   In addition, this patch clarifies
LayerTreeRenderer::setRootLayerID() can be
> +	   called only once in its lifecycle. LayerTreeRenderer,
LayerTreeCoordinator and
> +	   LayerTreeCoordinatorProxy belong to WebPage, so those have the same
lifecycle

Different patch.


More information about the webkit-reviews mailing list