[webkit-reviews] review granted: [Bug 103830] nrwt: clean up exception propagation / handling for interrupts and early exits : [Attachment 177126] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 103830: nrwt: clean up exception propagation / handling for interrupts and
early exits
https://bugs.webkit.org/show_bug.cgi?id=103830

Attachment 177126: Patch
https://bugs.webkit.org/attachment.cgi?id=177126&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177126&action=review


> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:437
> +	   logging.getLogger().setLevel(logging.DEBUG if
options.debug_rwt_logging else logging.INFO)

Nit: this doesn't need to be in the try, right? In fact, maybe it makes the
most sense right after we do the options parsing? In theory, the other code
(e.g. the Host constructor) could log stuff.