[webkit-reviews] review denied: [Bug 102438] [Gtk] navigator.plugins contains too many plugin entries. First one are garbages : [Attachment 174763] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied arno. <arno at renevier.net>'s request
for review:
Bug 102438: [Gtk] navigator.plugins contains too many plugin entries. First one
are garbages
https://bugs.webkit.org/show_bug.cgi?id=102438

Attachment 174763: Patch
https://bugs.webkit.org/attachment.cgi?id=174763&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174763&action=review


Looks good, r- with just a couple of minor comments.

> Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp:87
> +    outPlugins.resize(0);

If you look at PluginData::initPlugins() there's an ASSERT(m_plugins.isEmpty())
before calling this method, so I think we can just get rid of the resize(0)
too, the vector will be empty always.

> LayoutTests/plugins/navigator-plugins.html:29
> +</body>

Hrm, it seems this could just be a pure js test in plugins/script-tests no?
Look at navigator-mimeTypes-length.js for instance.