No subject


Wed Aug 1 07:28:53 PDT 2012


> Source/WebCore/rendering/RenderWidget.cpp:128
> +	   FrameView* frameView =3D static_cast<FrameView*>(m_widget.get());
> +	   Document* childDocument =3D frameView->frame()->document();
> +	   if (childDocument->attached())
> +	       childDocument->detach();

This seems like it should be done with a suitably-named FrameView function
rather than code reaching through the frame view and doing this directly on=
 the
document. Maybe even a virtual function on Widget?

> LayoutTests/fast/frames/ancestor-style-change.html:10
> +    window.wrapper =3D document.getElementById("wrapper").style.display =
=3D
"none";

What is the window.wrapper part of this line for?=


More information about the webkit-reviews mailing list