[webkit-reviews] review requested: [Bug 95519] Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive : [Attachment 161804] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 31 18:06:56 PDT 2012


Elliott Sprehn <esprehn at chromium.org> has asked  for review:
Bug 95519: Add new V8DependentRetained that allows keeping a v8::Object alive
as long as another v8::Object is alive
https://bugs.webkit.org/show_bug.cgi?id=95519

Attachment 161804: Patch
https://bugs.webkit.org/attachment.cgi?id=161804&action=review

------- Additional Comments from Elliott Sprehn <esprehn at chromium.org>
Make this thread safe, fix NUL termination, and make get() faster by using a
separate weak Handle. In discussions with adamk and ojan, and per Arvs comment
it seems like we should use a little more memory here and not worry about the
hashing speed for access. You're likely to have only a few MutationObservers or
DOMTransactions, but they may execute many times.


More information about the webkit-reviews mailing list