[webkit-reviews] review granted: [Bug 95616] [WK2] WebProcesses should not wait 60 seconds to close in multi-process mode : [Attachment 161786] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 95616: [WK2] WebProcesses should not wait 60 seconds to close in
multi-process mode
https://bugs.webkit.org/show_bug.cgi?id=95616

Attachment 161786: proposed patch
https://bugs.webkit.org/attachment.cgi?id=161786&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161786&action=review


r=me assuming you fix the bool/double thing

> Source/WebKit2/Shared/Plugins/PluginProcessCreationParameters.h:53
> +    bool terminationTimeout;

This needs to be double, right?

> Source/WebKit2/UIProcess/WebContext.cpp:89
> +static const double sharedSecondaryProcessShutdownTimeout = 60;

Add a comment about why 60 seconds is a good value?

> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:50
> +static const double shutdownTimeout = 15;

Add a comment about why 15 seconds is a good value?