[webkit-reviews] review denied: [Bug 95529] [chromium] Rename WebViewClient::handleDisambiguationPopup : [Attachment 161622] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 31 15:51:09 PDT 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 95529: [chromium] Rename WebViewClient::handleDisambiguationPopup
https://bugs.webkit.org/show_bug.cgi?id=95529

Attachment 161622: Patch
https://bugs.webkit.org/attachment.cgi?id=161622&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161622&action=review


>> Source/WebKit/chromium/public/WebViewClient.h:291
>> +	virtual bool multipleTargetsTapped(const WebGestureEvent&, const
WebVector<WebRect>& targetRects) { return false; }
> 
> didTapMultipleTargets or willTapMultipleTargets?

+1 ... probably didTap* since this is called from handleGestureEvent.  The tap
already happened.


More information about the webkit-reviews mailing list