[webkit-reviews] review granted: [Bug 95550] Build warning : -Wformat on WebMemorySampler.cpp. : [Attachment 161658] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Byungwoo Lee <bw80.lee at samsung.com>'s
request for review:
Bug 95550: Build warning : -Wformat on WebMemorySampler.cpp.
https://bugs.webkit.org/show_bug.cgi?id=95550

Attachment 161658: Patch
https://bugs.webkit.org/attachment.cgi?id=161658&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161658&action=review


A better fix would probably be to use String::number instead of String::format.


>> Source/WebKit2/Shared/WebMemorySampler.cpp:178
>> +		statString.append(String::format("%lu", static_cast<long
unsigned int>(memoryStats.values[i])));
> 
> Is it enough *unsigned long* ?

That’s right. In our code we use the name “unsigned long” for this type, not
“long unsigned int”, which is equivalent, but not idiomatic. When landing this
please use “unsigned long” rather than “long unsigned int”.