[webkit-reviews] review denied: [Bug 94712] High memory usage spike in AssemblerBuffer : [Attachment 161564] Updated according to Ben's comments. also created AssemblerBufferSegmented

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 31 11:51:15 PDT 2012


Gavin Barraclough <barraclough at apple.com> has denied Yong Li <yoli at rim.com>'s
request for review:
Bug 94712: High memory usage spike in AssemblerBuffer
https://bugs.webkit.org/show_bug.cgi?id=94712

Attachment 161564: Updated according to Ben's comments. also created
AssemblerBufferSegmented
https://bugs.webkit.org/attachment.cgi?id=161564&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
We work very hard to keep the JIT cross platform.  This change is great, but we
are concerned about peak memory usage on x86 too, there is absolutely no
justification to fork the AssemblerBuffer here, and to do so will detrimental
to the long term maintainability of the project.  If I have time I'll try to
look at what the problem is you're having on x86, and see if I am able to give
you any further advice to to try to take this patch to completion as
efficiently as possible.


More information about the webkit-reviews mailing list