[webkit-reviews] review granted: [Bug 95546] [DRT] Make simulating a web click on a notification a queued task : [Attachment 161730] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 95546: [DRT] Make simulating a web click on a notification a queued task
https://bugs.webkit.org/show_bug.cgi?id=95546

Attachment 161730: Patch
https://bugs.webkit.org/attachment.cgi?id=161730&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

I suggest adding an ASSERT(!m_hasPendingWebNotificationClick) when DRT is
dumping test results - the m_hasPendingWebNotificationClick check in dispatched
block is insufficient for safety. If one test calls
simulateWebNotificationClick, finishes, and then another one does the same,
we'll end up dispatching original notificationID, breaking the second test.