[webkit-reviews] review granted: [Bug 95480] Repaints should not be deferred after initial page load is complete : [Attachment 161727] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 95480: Repaints should not be deferred after initial page load is complete
https://bugs.webkit.org/show_bug.cgi?id=95480

Attachment 161727: patch
https://bugs.webkit.org/attachment.cgi?id=161727&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161727&action=review


> Source/WebCore/ChangeLog:21
> +	   (WebCore):

You can remove this line.

> Source/WebCore/loader/FrameLoader.cpp:758
> +	   m_frame->view()->checkStopDelayingDeferredRepaints();

I have a hard time parsing this function name. Maybe we can rename it?

> Source/WebCore/page/FrameView.cpp:104
> +double FrameView::s_normalDeferredRepaintDelay = 0.025;

Should we make this 16ms to avoid crapping on animations?

> Source/WebCore/page/FrameView.cpp:2059
> +    double increamentedRepaintDelay = m_deferredRepaintDelay +
s_deferredRepaintDelayIncrementDuringLoading;

increamentedRepaintDelay -> incrementedRepaintDelay