[webkit-reviews] review granted: [Bug 95586] [New Multicolumn] Refactor flow thread repainting. : [Attachment 161724] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 95586: [New Multicolumn] Refactor flow thread repainting.
https://bugs.webkit.org/show_bug.cgi?id=95586

Attachment 161724: Patch
https://bugs.webkit.org/attachment.cgi?id=161724&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161724&action=review


> Source/WebCore/ChangeLog:10
> +	   inside sets.

Not sure what "sets" are in this context.

> Source/WebCore/rendering/RenderFlowThread.cpp:322
> +    // We can't use currentFlowThread as it is possible to have imbricated
flow threads and the wrong one could be used.

99.9% of people won't know what "imbricated" means, even though it's cool.
Maybe "overlapping"?

> Source/WebCore/rendering/RenderRegion.h:72
> +    

Redundant whitespace