[webkit-reviews] review granted: [Bug 95575] [Qt] ImageDiff output is not in the expected form if image dimensions differ : [Attachment 161705] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 95575: [Qt] ImageDiff output is not in the expected form if image
dimensions differ
https://bugs.webkit.org/show_bug.cgi?id=95575

Attachment 161705: Patch
https://bugs.webkit.org/attachment.cgi?id=161705&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161705&action=review


LGTM, r=me with some minor nit.

> Tools/ChangeLog:8
> +
> +

nit: - an empty line :)

> Tools/DumpRenderTree/qt/ImageDiff.cpp:87
> +		   fputs("diff: 100%% failed\n", stdout);

Could you use fprintf as everywhere else?