[webkit-reviews] review denied: [Bug 95519] Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive : [Attachment 161599] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 95519: Add new V8DependentRetained that allows keeping a v8::Object alive
as long as another v8::Object is alive
https://bugs.webkit.org/show_bug.cgi?id=95519

Attachment 161599: Patch
https://bugs.webkit.org/attachment.cgi?id=161599&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161599&action=review


> Source/WebCore/ChangeLog:11
> +	   v8::Object is alive. This is useful for keeping callbacks attached
to wrappers without
> +	   keeping strong references to v8::Objects in the C++ side which can
result in leaks
> +	   when cycles are created.

Would you elaborate on what use cases you are assuming?

> Source/WebCore/ChangeLog:13
> +	   No new tests needed, this will be used to fix MutationObservers
which will have tests.

I might want to see the patch to understand use cases.

> Source/WebCore/bindings/v8/V8DependentRetained.h:76
> +	   static double nextId = 0;

This is not thread-safe (i.e. not Worker-safe).