[webkit-reviews] review requested: [Bug 95532] [EFL] Add proper support for navigator.onLine and associated events : [Attachment 161672] Fixed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 31 05:25:38 PDT 2012
Christophe Dumez <christophe.dumez at intel.com> has asked for review:
Bug 95532: [EFL] Add proper support for navigator.onLine and associated events
https://bugs.webkit.org/show_bug.cgi?id=95532
Attachment 161672: Fixed patch
https://bugs.webkit.org/attachment.cgi?id=161672&action=review
------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Fix 2 issues with the first version of the patch
1. use ssize_t instead of size_t for len (used to store return value of
recv()). We cannot use size_t since recv() returns -1 when there is nothing to
read anymore.
2. Use MSG_DONTWAIT flag for recv() to make the operation non-blocking.
Setting r? again since those are not style changes.
More information about the webkit-reviews
mailing list